]> dgit.raspbian.org Git - gnome-shell.git/commit
theme: Don't give login-dialog another background-color
authorDaniel van Vugt <daniel.van.vugt@canonical.com>
Fri, 23 Feb 2024 07:29:56 +0000 (15:29 +0800)
committerMarge Bot <marge-bot@gnome.org>
Wed, 28 Feb 2024 14:55:39 +0000 (14:55 +0000)
commitd09509b2cbce0d21c68d40a765a0880743a3ef5e
tree7bd08445fa48d280e570da847ee4f4b99cd0babd
parente46b137b424a24515d4008232fcecd4bf8e9eaab
theme: Don't give login-dialog another background-color

Its parent `lockDialogGroup` has exactly the same background-color
set in the same file. Giving them both the same wasted render time on
overdraw, and caused multi-layer blending artifacts (slight flickering
of the grey background) when the login dialog fades in/out.

While the flicker can also be fixed using `set_offscreen_redirect`,
there's no point adding that overhead when the extra layer doesn't need
to be painted. Removing it halves the average render time of the login
animation.

Closes: https://bugs.launchpad.net/bugs/2036388
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3207>
data/theme/gnome-shell-sass/widgets/_login-lock.scss